修复notification组件，当项目同时存在设置了offset和没设置offset的通知弹窗，导致通知弹窗重叠的问题 #21222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for element ready! 🔨 Explore the source changes: 420fa6b 🔍 Inspect the deploy log: https://app.netlify.com/sites/element/deploys/61148bf4838a110008bf9140 😎 Browse the preview: https://deploy-preview-21222--element.netlify.app/ |
wangdaodao
reviewed
Aug 12, 2021
| @@ -37,7 +37,7 @@ const Notification = function(options) { | |||
|
|
|||
| let verticalOffset = options.offset || 0; | |||
| instances.filter(item => item.position === position).forEach(item => { | |||
| verticalOffset += item.$el.offsetHeight + 16; | |||
| verticalOffset += item.offset + item.$el.offsetHeight + 16; | |||
There was a problem hiding this comment.
item.offset 有可能是 undefined，另外一旦加上偏移量，偏移间隔就会很大。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改bug： notification弹窗重叠
场景：项目中有多个通知弹窗，有些通知设置了offset且不会自动消失，有些没有设置offset
定位原因：element计算新通知位置时，没有将已存在通知的offset加上，其他类型的弹窗可能也有类似问题