Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复notification组件，当项目同时存在设置了offset和没设置offset的通知弹窗，导致通知弹窗重叠的问题 #21222

Closed
wants to merge 1 commit into from
Closed

修复notification组件，当项目同时存在设置了offset和没设置offset的通知弹窗，导致通知弹窗重叠的问题 #21222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/notification/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const Notification = function(options) {

let verticalOffset = options.offset || 0;
instances.filter(item => item.position === position).forEach(item => {
verticalOffset += item.$el.offsetHeight + 16;
verticalOffset += item.offset + item.$el.offsetHeight + 16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item.offset 有可能是 undefined，另外一旦加上偏移量，偏移间隔就会很大。

});
verticalOffset += 16;
instance.verticalOffset = verticalOffset;
Expand Down