Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant pegin mempool check #624

Closed
stevenroose opened this issue May 20, 2019 · 1 comment · Fixed by #627
Closed

Remove redundant pegin mempool check #624

stevenroose opened this issue May 20, 2019 · 1 comment · Fixed by #627

Comments

@stevenroose
Copy link
Member

https://github.com/ElementsProject/elements/blob/master/src/txmempool.cpp#L591

That check should be redundant since the spending of pegins is handled using the regular double spend prevention checks.
@instagibbs
Copy link
Collaborator

mapPeginsSpentToTxid is likely completely redundant due to the peg-in prevout being spent maps exactly to the txid from the parent chain

@instagibbs instagibbs mentioned this issue May 21, 2019
Merged
stevenroose added a commit that referenced this issue May 29, 2019
@stevenroose
Merge #627: kill useless mapPeginsSpentToTxid
e1bf441 
8591de9 kill useless mapPeginsSpentToTxid (Gregory Sanders)

Pull request description:

  Completely redundant since #260 when peg-in inputs have taken on deterministic prevouts, so normal mempool logic has taken over for accounting for double-spending peg-in proofs in the mempool.

  resolves #624

Tree-SHA512: e5c0e7570657bd1418f54fdd47a6f3f815a5779e28ff15ba37c18e425780415385af64efa57be882ba12ad748e7a664fb723eae0e819bf1d5f197bb0b82b086b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kill useless mapPeginsSpentToTxid instagibbs/elements
2 participants
@stevenroose @instagibbs