Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide blinding factors for explicit outputs in gettransactoin and listunspent #883

Open
stevenroose opened this issue Jun 3, 2020 · 0 comments
Open

Hide blinding factors for explicit outputs in gettransactoin and listunspent #883

stevenroose opened this issue Jun 3, 2020 · 0 comments

Comments

@stevenroose
Copy link
Member

stevenroose commented Jun 3, 2020 •
edited
Loading

Currently for explicit outputs gettransaction shows this:

    "details": [
        {
            "category": "generate",
            "amount": 0.00104720,
            "amountblinder": "0000000000000000000000000000000000000000000000000000000000000000",
            "asset": "0a8e7509f0ab8b750909e378b51af66158464430b88d8efb0627b0b6226f91ea",
            "assetblinder": "0000000000000000000000000000000000000000000000000000000000000000",
            "vout": 0
        }

It's probably better to just hide the blinding factors there instead of showing 00000.

Same for listunspent:

{
        "txid": "05df25d4c8c94aaf6c5538d6aed22803abb524cbc6ab115811de3d7716c3e458",
        "vout": 0,
        "scriptPubKey": "51",
        "amount": 0.00104720,
        "asset": "0a8e7509f0ab8b750909e378b51af66158464430b88d8efb0627b0b6226f91ea",
        "amountblinder": "0000000000000000000000000000000000000000000000000000000000000000",
        "assetblinder": "0000000000000000000000000000000000000000000000000000000000000000",
        "confirmations": 8003,
        "spendable": true,
        "solvable": true,
        "desc": "raw(51)#8lvh9jxk",
        "safe": true
}
@stevenroose stevenroose changed the title Hide blinding factors for explicit outputs in gettransactoin "details" Hide blinding factors for explicit outputs in gettransactoin and listunspent Jun 3, 2020
gwillen pushed a commit that referenced this issue Mar 3, 2021
Merge #16225: tests: Make coins_tests/updatecoins_simulation_test det…
98958c8 
…erministic

f899580 tests: Make coins_tests/updatecoins_simulation_test deterministic (practicalswift)

Pull request description:

  Make `coins_tests/updatecoins_simulation_test` deterministic.

  Before:

  ```
  $ contrib/devtools/test_deterministic_coverage.sh 1000
  [2019-06-15 05:36:20] Measuring coverage, run #1 of 1000
  [2019-06-15 05:38:05] Measuring coverage, run #2 of 1000
  [2019-06-15 05:39:49] Measuring coverage, run #3 of 1000
  [2019-06-15 05:41:38] Measuring coverage, run #4 of 1000
  [2019-06-15 05:43:16] Measuring coverage, run #5 of 1000
  ...
  [2019-06-16 18:25:23] Measuring coverage, run #880 of 1000
  [2019-06-16 18:27:12] Measuring coverage, run #881 of 1000
  [2019-06-16 18:29:33] Measuring coverage, run #882 of 1000
  [2019-06-16 18:33:00] Measuring coverage, run #883 of 1000
  [2019-06-16 18:35:32] Measuring coverage, run #884 of 1000

  The line coverage is non-deterministic between runs. Exiting.

  The test suite must be deterministic in the sense that the set of lines executed at least
  once must be identical between runs. This is a necessary condition for meaningful
  coverage measuring.

  --- gcovr.run-1.txt     2019-06-15 05:38:05.282359029 +0200
  +++ gcovr.run-884.txt   2019-06-16 18:37:23.518298374 +0200
  @@ -269,7 +269,7 @@
   test/bloom_tests.cpp                         320     320   100%
   test/bswap_tests.cpp                          13      13   100%
   test/checkqueue_tests.cpp                    223     222    99%   169
  -test/coins_tests.cpp                         478     472    98%   52,68,344-345,511,524
  +test/coins_tests.cpp                         478     474    99%   52,68,511,524
   test/compilerbug_tests.cpp                    18      18   100%
   test/compress_tests.cpp                       27      27   100%
   test/crypto_tests.cpp                        268     268   100%
  @@ -401,5 +401,5 @@
   zmq/zmqpublishnotifier.h                       5       0     0%   12,31,37,43,49
   zmq/zmqrpc.cpp                                23       3    13%   16,18,20,23,33-35,37,40-47,51,62,64-65
   ------------------------------------------------------------------------------
  -TOTAL                                      53323   28305    53%
  +TOTAL                                      53323   28307    53%
   ------------------------------------------------------------------------------
  ```

  After:

  ```
  $ contrib/devtools/test_deterministic_coverage.sh 1000
  [2019-06-15 05:36:20] Measuring coverage, run #1 of 1000
  [2019-06-15 05:38:05] Measuring coverage, run #2 of 1000
  [2019-06-15 05:39:49] Measuring coverage, run #3 of 1000
  [2019-06-15 05:41:38] Measuring coverage, run #4 of 1000
  [2019-06-15 05:43:16] Measuring coverage, run #5 of 1000
  ...
  $
  ```

ACKs for commit f89958:
  MarcoFalke:
    ACK f899580 (checked that the randomness state of g_insecure_rand_ctx is the same after three test runs)

Tree-SHA512: 796d362b050c5750e351de1126b62f0f2c8e2d712cf01b6e1a3e2cc6ef92fa68439a32fc24c76d34bce4d553aee4ae4ea88a036c56eb9e25979649a19c59c3e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevenroose