Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix elements naming in gitian builds #1128

Merged
merged 1 commit into from Sep 9, 2022
Merged

Fix elements naming in gitian builds #1128

merged 1 commit into from Sep 9, 2022

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Aug 1, 2022

Currently, our gitian builds for releases generate tarballs called elements-elements-xxxxx instead of elements-xxxxx. This is fixed by correctly trimming the elements- prefix in our release tags (just as bitcoin trims the initial v)

@psgreco psgreco requested a review from sipa as a code owner August 1, 2022 19:38
delta1
delta1 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c6677f8 this change will remove the first instance of elements- in the RECENT_TAG var

@psgreco
Copy link
Contributor Author

psgreco commented Aug 2, 2022

utACK c6677f8 this change will remove the first instance of elements- in the RECENT_TAG var

yes, bitcoin tags their releases with vXXXX, we tag them with elements-XXXX, this patch strips the elements- prefix the same way bitcoin removes their v

@jamesdorfman jamesdorfman merged commit c3834f7 into ElementsProject:elements-0.21 Sep 9, 2022
@psgreco psgreco deleted the elements-0.21-fixgitian branch September 16, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 approved these changes

@sipa sipa Awaiting requested review from sipa sipa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psgreco @delta1 @jamesdorfman