Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct testproposedblock help #1216

Merged

Conversation

jhfrontz
Copy link
Contributor

@jhfrontz jhfrontz commented Mar 4, 2023

The help message for testproposedblock erroneously indicates that some checking will be done against the PAK list. There are no [longer any] such checks.

@jhfrontz jhfrontz requested a review from instagibbs March 4, 2023 00:48
@delta1
Copy link
Member

delta1 commented Mar 4, 2023

Is this based on the simplicity branch? Should that be the merge target, or rebase this on master?

@psgreco psgreco force-pushed the correct_testproposedblock_help branch from 0b77cd1 to 1b04245 Compare March 5, 2023 12:06
@psgreco
Copy link
Contributor

psgreco commented Mar 5, 2023

The help message fixed here was related to the code Introduced in 1241343, which was removed in 47db75e.

ACK 1b04245

Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1b04245

@delta1 delta1 merged commit b4ba5c7 into ElementsProject:master Mar 5, 2023
jamesdorfman added a commit to jamesdorfman/elements that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants