Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplicity #1219

Draft
wants to merge 15 commits into
base: elements-22.x
Choose a base branch
from
Draft

Simplicity #1219

wants to merge 15 commits into from

Conversation

roconnor-blockstream
Copy link
Contributor

@roconnor-blockstream roconnor-blockstream commented Mar 7, 2023 •
edited

Tasks needed to pass CI:

  • For Mingw32, remove pthread dependency from Simplicity (upstream).
  • Merge (upcoming) libsecp256k1 release into Simplicity (upstream).

Tasks needed for public signet:

  • Add weight requirements for jets and combinantors (upstream).
  • Maximum memory allocation (upstream).
  • Other missing anti-DOS protection (upstream)?

Tasks needed for testing.

  • Ensure that the fuzzer covers libelementssimplicity.

Before merging:

  • Rebase on master.

uncomputable and others added 5 commits November 15, 2023 21:36
@uncomputable
Asset tests: Add VERIFY_SCRIPT_SIMPLICITY flag
87a2b10 
Include Simplicity in the script verification flags.
Update the flag parser.
@uncomputable
Asset tests: Parse Elements script errors
14049d0 
Take the existing function to parse script errors and extend it to parse
Elements errors. SCRIPT_ERR_ERROR_COUNT is not included because it is a
pseudo error.
@uncomputable
Asset tests: Check script error
26691db 
Compare the expected script error, parsed from JSON, with the actual
error that VerifyScript returns. If the JSON does not include an
expected error, then skip this check.
@delta1
Merge pull request #1280 from uncomputable/simplicity
7ab6ded 
Enable Simplicity script tests
@uncomputable @roconnor-blockstream
Script: Add SCRIPT_ERR_SIMPLICITY_HIDDEN_ROOT
dc32f28 
The included Simplicity already supports this error, but Elements
converted it into SCRIPT_ERR_UNKNOWN_ERROR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roconnor-blockstream @uncomputable @delta1