Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting parent chain address prefix in configuration file #363

Merged

Conversation

instagibbs
Copy link
Collaborator

Default is testnet, as before.

@jtimon
Copy link
Contributor

jtimon commented May 31, 2018

Concept ACK, this is more generic than c23cc1b
Perhaps #362 could actually be a good way to test it.

Why change the default though?

@instagibbs
Copy link
Collaborator Author

Why change the default though?

I didn't.

@instagibbs
Copy link
Collaborator Author

"Perhaps #362 could actually be a good way to test it."

I just tested it manually. You could have a test just set it and make sure the address leading character matches: https://en.bitcoin.it/wiki/List_of_address_prefixes

@instagibbs
Copy link
Collaborator Author

had the wrong default in the help. Fixed.

@jtimon
Copy link
Contributor

jtimon commented Jun 1, 2018

utACK 3832e4a

@instagibbs instagibbs merged commit 3832e4a into ElementsProject:elements-0.14.1 Jun 1, 2018
instagibbs added a commit that referenced this pull request Jun 1, 2018
…n file

3832e4a allow setting parent chain address prefix in configuration file (Gregory Sanders)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants