qa: Use bitcoind as parent in Travis tests #418
Conversation
stevenroose
force-pushed
the
fedpeg-bitcoind-travis
branch
from
4b73a89
to
6aa5ef9
Compare
.travis.yml
Outdated
| @@ -30,6 +30,7 @@ env: | |||
| # Win64 | |||
| - HOST=x86_64-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports" | |||
| # bitcoind | |||
| - HOST=i686-pc-linux-gnu PACKAGES="g++-multilib bc python3-zmq" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1" RUN_TESTS=true RUN_FEDPEG_BITCOIND=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER" | |||
There was a problem hiding this comment.
We're running into the exact some OOB issue here with the build below...
There was a problem hiding this comment.
Yeah so I have no idea what build to add the RUN_FEDPEG_BITCOIND to add to then :D
There was a problem hiding this comment.
one that's currently running? :P
chasing this down
There was a problem hiding this comment.
if you want to add a new test that won't fail, take away DEBUG=1. This is what enforces the stricter debugging mode that is getting tripped up.
There was a problem hiding this comment.
or we merge #419 first then rebase
|
Looks like it can't find the file. |
|
Needs rebase now that we've fixed |
stevenroose
force-pushed
the
fedpeg-bitcoind-travis
branch
7 times, most recently
from
40923f2
to
9fbebf1
Compare
stevenroose
changed the title
|
Works now :) @jtimon |
|
itshappening.gif |
.travis.yml
Outdated
| @@ -70,6 +70,11 @@ script: | |||
| - export LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib | |||
| - if [ "$RUN_TESTS" = "true" ]; then make $MAKEJOBS check VERBOSE=1; fi | |||
| - if [ "$RUN_TESTS" = "true" ]; then qa/pull-tester/rpc-tests.py --coverage; fi | |||
| - if [ "$RUN_FEDPEG_BITCOIND" = "true" ]; then BITCOIND_VERSION=0.16.3; fi | |||
There was a problem hiding this comment.
any particular reason this can't be one big block inside one conditional?
There was a problem hiding this comment.
Just readability I guess. You prefer it alltogether? I know it's a bit stupid to take 5 lines for one extra thing, but those files are already so unreadable, didn't want to contribute more to that.
I could add all the install stuff in one line and then the actual test in a second. Will be one long line though :D
There was a problem hiding this comment.
Can't set the variables in the same line as doing 3 commands they don't ripple through. So now have var line, install line and test line.
stevenroose
force-pushed
the
fedpeg-bitcoind-travis
branch
from
9fbebf1
to
9975d1c
Compare
|
Awesome.
Not on my computer, but it seems there's a 0.16.3 in the second line that
could be replace with the version var too.
…On Fri, 28 Sep 2018, 11:14 Steven Roose, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#418 (comment)>
:
> @@ -70,6 +70,11 @@ script:
- export LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib
- if [ "$RUN_TESTS" = "true" ]; then make $MAKEJOBS check VERBOSE=1; fi
- if [ "$RUN_TESTS" = "true" ]; then qa/pull-tester/rpc-tests.py --coverage; fi
+ - if [ "$RUN_FEDPEG_BITCOIND" = "true" ]; then BITCOIND_VERSION=0.16.3; fi
Can't set the variables in the same line as doing 3 commands they don't
ripple through. So now have var line, install line and test line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#418 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9jShXiC356NLMcUFQWx15BEPZeeLO-ks5ufeiKgaJpZM4W5G1G>
.
|
stevenroose
force-pushed
the
fedpeg-bitcoind-travis
branch
from
9975d1c
to
7e02f39
Compare
|
@jtimon Whoops, that is very much true. Fixed that. |
|
bitcoind test is taking too long for some reason: |
|
restarting job to see if this repeats. |
|
I've seen that error on my machine too. Second attempt usually works. |
|
ACK, moar testing |
7e02f39 qa: Use bitcoind as parent in Travis tests (Steven Roose)
No description provided.