Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoice timeout is too short, should be more flexible #2551

Closed
rustyrussell opened this issue Apr 10, 2019 · 0 comments
Closed

invoice timeout is too short, should be more flexible #2551

rustyrussell opened this issue Apr 10, 2019 · 0 comments
Assignees
@rustyrussell
Labels
enhancement invoice
Milestone
0.7.1

Comments

@rustyrussell
Copy link
Contributor

For casual invoices, 1 hr is too brief: 1-7 days seems more reasonable. And expressing that in seconds is just annoying...
@rustyrussell rustyrussell added this to the 0.7.1 milestone Apr 10, 2019
@rustyrussell rustyrussell self-assigned this Apr 10, 2019
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 10, 2019
@rustyrussell
invoice: allow suffixes.
0bf1abb 
Makes it much easier to set it to 6 hours, for example.

Fixes: ElementsProject#2551
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 10, 2019
@rustyrussell
invoice: allow suffixes.
7b5ae2b 
Makes it much easier to set it to 6 hours, for example.

Fixes: ElementsProject#2551
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Apr 10, 2019
@rustyrussell
invoice: allow suffixes.
ec6719d 
Makes it much easier to set it to 6 hours, for example.

Fixes: ElementsProject#2551
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
enhancement invoice
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
1 participant
@rustyrussell