-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some aliases no longer visible in listnodes #3194
Comments
Which version ? There has been some gossip fixups between the rcs. |
Version: v0.7.3rc3 (that was written under getinfo output.) but the problem started already with rc2. |
missing aliases is a side-effect of your node not having the node_announcement gossip message for that node. prior RC's of c-lightning weren't being very aggressive with pushing out their own node_announcements, see #3152 |
@niftynei So it's only a problem with c-lightning versions 0.7.3.rc1 and/or 0.7.3.rc2 or also with older versions of c-lightning? If only with the two rcs, I will close the issue. |
It was a problem in 0.7.2 too. See #2969. I am still experiencing the issue on 0.7.3rc3. Even after my node has been running for three days on 0.7.3rc3, I am still missing node announcements for a sizable fraction of my connected peers. |
There are two issues to discuss here, which have the same net result— your node appears to be missing aliases for other nodes. In the case of “my node is missing alias information from recent c-lightning nodes”, this is likely due to them not sending them very aggressively. #3152 addresses this, but requires affected nodes to upgrade In the case of “Im missing large swaths of aliases from nodes, not just from clightning peers”, this is typically a result of not asking our peers for a wide enough range to net the missing information. It should be fixed in RC3 (we now look for a wide range of missing node announcements to ask our peers about). If you’re still having trouble, you can give it a kick by deleting* your gossip store, this will resync all the gossip en masse. Note that if the reason they’re missing is because the above issue, this won’t do much to help as it’s unlikely your peers have the missing information either. *i.e. stop your node, rename the gossip store to |
@niftynei: Thanks for the clarifications. Even if I don't zap my |
@whitslack well that depends on why the announcements are missing. assuming that they’re relatively well represented on other nodes, they should get picked up by the gossip seeker eventually. I’d need to check but I believe it was changed to run once every ~24hrs |
@niftynei: 100 of my 386 peers are showing no alias and no color after my node has been up for 62 hours. Does this suggest that the seeker is malfunctioning?
|
I've updated to the latest version ( Using whitslack's command: false 7 |
Yep, I've seen this on my node and it's indeed only C-lightning nodes. They might not have upgraded yet. |
@darosior: How do you tell what software your peer is running? I'd love to instrument that, but I haven't found a way. |
Actually checking 1ML ^^ |
@whitslack I only know they are c-lightning nodes because I decided to only connect to c-lightning nodes a couple of months ago when I was often getting fatal errors with LND nodes (this issue has now been resolved by ignoring these error messages). I found the c-lightning nodes looking for node IDs in the issues. Nevertheless an interesting question. |
Unfortunately so I did... |
I updated my node from 7.2 to 7.3 and I have the same problem. only 1038 of 4615 listed nodes are not empty. |
Hello @poperbu, it must be due to the remote side which has not updated yet |
ok, I understand now,...so We need to wait that all nodes update their info? It is a problem for plugins and tools that use listnodes calls, if we need to wait long time to know the alias... |
As much as I would love to believe that 114 of my 392 peers are running buggy C-Lightning release candidates, I think we all know that C-Lightning just isn't that popular. No, our lack of node announcements is not solely due to a plethora of buggy C-Lightning release candidates running in the wild. It is evident that there is still a logic error in the gossip code of C-Lightning 0.7.3. |
It really, really doesn't matter. But we were dramatically reducing our view of the network: In my gossip_store (mainnet): channel_announcement: 30349 channel_update: 55119 node_announcment: 1783 Changelog-Fixed: No longer discard most node_announcements (fixes ElementsProject#3194) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It really, really doesn't matter. But we were dramatically reducing our view of the network: In my gossip_store (mainnet): channel_announcement: 30349 channel_update: 55119 node_announcment: 1783 Changelog-Fixed: No longer discard most node_announcements (fixes #3194) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Yep, this commit solves the issue. Thanks to all! |
OK, if you want to fix existing nodes, I've written a script to do so. I've appended it to the Release files, along with a canned set of node_announcements for mainnet https://github.com/ElementsProject/lightning/releases/download/v0.7.3/insert-unknown-nodes.sh |
I automatically find aliases via:
lightning-cli listnodes
Since I updated to
v0.7.3
some aliases are no longer part oflistnodes
. The IDs are there but without aliases. I suspect it happens with c-lightning versions<= 0.7.2
. LND and Eclair aliases seem the same (see my website and look for alias_unknown)For example
ln.rene-pickhardt.de
. The node ID is inlistnodes
(I even have a channel with that node) but without the alias.getinfo
outputAlias: Bitkoins.nl
Version: v0.7.3rc3"
The text was updated successfully, but these errors were encountered: