Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using wrong dust_limit as floor for channel_reserve #4140

Closed
niftynei opened this issue Oct 19, 2020 · 0 comments · Fixed by #4141
Closed

Using wrong dust_limit as floor for channel_reserve #4140

niftynei opened this issue Oct 19, 2020 · 0 comments · Fixed by #4141
Assignees
@niftynei

Comments

@niftynei
Copy link
Collaborator

We should be using the opener's dust_limit as the channel_reserve floor, not the local dust_limit.

image

https://github.com/ElementsProject/lightning/blob/master/openingd/openingd.c#L211-L214

https://github.com/ElementsProject/lightning/blob/master/openingd/openingd.c#L896-L915

Encountered by @PsySc0rpi0n
@niftynei niftynei self-assigned this Oct 19, 2020
niftynei added a commit to niftynei/lightning that referenced this issue Oct 20, 2020
@niftynei
opening: use correct dust_limit for reserve floor
8da3471 
Fixes ElementsProject#4140

Reported-By: @PsySc0rpi0n
@niftynei niftynei mentioned this issue Oct 20, 2020
Merged
niftynei added a commit to niftynei/lightning that referenced this issue Oct 20, 2020
@niftynei
opening: use correct dust_limit for reserve floor
f209146 
Fixes ElementsProject#4140

Reported-By: @PsySc0rpi0n
Changelog-Fixed: openingd now uses the correct dust limit for determining the allowable floor for a channel open (affects fundee only)
rustyrussell pushed a commit that referenced this issue Oct 21, 2020
@niftynei @rustyrussell
opening: use correct dust_limit for reserve floor
ae825ff 
Fixes #4140

Reported-By: @PsySc0rpi0n
Changelog-Fixed: openingd now uses the correct dust limit for determining the allowable floor for a channel open (affects fundee only)
vibhaa pushed a commit to spider-pcn/lightning that referenced this issue Mar 24, 2021
@niftynei @vibhaa
opening: use correct dust_limit for reserve floor
43b56fe 
Fixes ElementsProject#4140

Reported-By: @PsySc0rpi0n
Changelog-Fixed: openingd now uses the correct dust limit for determining the allowable floor for a channel open (affects fundee only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niftynei niftynei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

opening: use correct dust_limit for reserve floor niftynei/lightning
1 participant
@niftynei