Fix release zipfile #2247
Merged
Fix release zipfile #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb55
reviewed
Jan 11, 2019
CHANGELOG.md
Outdated
| @@ -230,7 +232,7 @@ There predate the BOLT specifications, and are only of vague historic interest: | |||
| 7. [0.5.2] - 2016-11-21: "Bitcoin Savings & Trust Daily Interest II" | |||
|
|
|||
| [Unreleased]: https://github.com/ElementsProject/lightning/compare/v0.6.2...HEAD | |||
| [0.6.3-rc1]: https://github.com/ElementsProject/lightning/compare/v0.6.3-rc1...HEAD | |||
| [0.6.3]: https://github.com/ElementsProject/lightning/compare/v0.6.3...HEAD | |||
There was a problem hiding this comment.
should this line be: https://github.com/ElementsProject/lightning/releases/tag/v0.6.3 ?
There was a problem hiding this comment.
and [Unreleased]: https://github.com/ElementsProject/lightning/compare/v0.6.3...HEAD
There was a problem hiding this comment.
Yeah, I fuxked up that should not have been here at all. Will force push
rustyrussell
force-pushed
the
fix-release-zipfile
branch
from
dbf1759
to
edf252a
Compare
|
if you have a fresh zip file generated from this I would be interested in testing it. for now I'm still using recursive clone in NixOS/nixpkgs#53732 |
|
Small fixup to fix the |
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changes both how we construct it and how we deal with not having git. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-release-zipfile
branch
from
6dcdd03
to
03cb926
Compare
|
Rebased onto master and folded @cdecker fix in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.