Makefile: fix occasional race where we fail to compile tools/tests. #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the dependencies: 1. Objs depend on headers, not other objs. 2. Programs depend on objs. 3. A .o file will generally implicitly depend on the .c file it's built from. 4. If a file has a build line, it's often better to list all deps there. 5. I spotted some missing 'make clean' files. The particular problem in this case seems to be that make would use tools/test/gen_test.c before it was ready. It's probably confused by the use of recursive make via update-mocks, so explicitly split that into two stages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
ACK bd2c860 |
niftynei
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the dependencies:
The particular problem in this case seems to be that make would use
tools/test/gen_test.c before it was ready. It's probably confused by
the use of recursive make via update-mocks, so explicitly split that
into two stages.
Signed-off-by: Rusty Russell rusty@rustcorp.com.au