Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix occasional race where we fail to compile tools/tests. #2962

Commits on Aug 16, 2019

  1. Makefile: fix occasional race where we fail to compile tools/tests.

    This simplifies the dependencies:
    1. Objs depend on headers, not other objs.
    2. Programs depend on objs.
    3. A .o file will generally implicitly depend on the .c file it's built from.
    4. If a file has a build line, it's often better to list all deps there.
    5. I spotted some missing 'make clean' files.
    
    The particular problem in this case seems to be that make would use
    tools/test/gen_test.c before it was ready.  It's probably confused by
    the use of recursive make via update-mocks, so explicitly split that
    into two stages.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    bd2c860 View commit details
    Browse the repository at this point in the history