Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore payment amount fuzzing #3212

Merged
merged 5 commits into from
Nov 8, 2019

Commits on Nov 6, 2019

  1. pay: restore payment value randomization through shadow routing

    When doing the random walk through the channel, we now add the fees
    (both the base and the proportional one) for that channel in addition to
    the cltv delta.
    
    Changelog-Added: Payment amount fuzzing is restored, but through shadow routing.
    darosior committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7e4ea52 View commit details
    Browse the repository at this point in the history
  2. common/json: add a helper for json to u16

    As Rusty pointed out to me, the gossip protocol restricts cltvs to u16
    so at least we'll use this helper for them.
    darosior committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    247c2c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. pay: add a dev-only parameter to deactivate shadow routing

    Had to make a special pylightning function to avoid rewriting all calls
    to 'pay()' with 'rpc.call()' in the next commit..
    darosior committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    db00602 View commit details
    Browse the repository at this point in the history
  2. pytest: deactivate shadow routing for some tests that use 'pay'

    So that we can assert payment values
    darosior committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    608d868 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    216dd35 View commit details
    Browse the repository at this point in the history