Display close_to address in listpeers
#3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Nov 8, 2019
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
|
|
There was a problem hiding this comment.
Needs rebase to use Changelog-Added: instead.
lightningd/peer_control.c
Outdated
| json_add_string(response, "close_to_addr", | ||
| encode_scriptpubkey_to_addr(tmpctx, | ||
| get_chainparams(ld), | ||
| channel->shutdown_scriptpubkey[LOCAL])); |
There was a problem hiding this comment.
Should we handle encode_scriptpubkey_to_addr returning NULL? The classic would be not to add the field if it's NULL...
There was a problem hiding this comment.
good idea. updated.
Previously, returned null if a scriptpubkey was not Segwit; now handles encoding to Base58 for other types.
If a 'upfront_shutdown_script' was specified, show the address + scriptpubky in `listpeers` Changelog-added: JSON API: `listpeers` channels now include `close_to` and `close_to_addr` iff a `close_to` address was specified at channel open
niftynei
force-pushed
the
nifty/upfront_to_listpeers
branch
from
9325204
to
87ff75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make close-to address more visible by printing in
listpeerschannels.