build: fix developer mode compilation on FreeBSD #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent FreeBSD versions use LLVM's lld as a linker, not the GNU ld. Their behavior slightly differs, so adapt the build system to handle either one. * The LLVM's linker prints "undefined symbol:" instead of "undefined reference to". Tweak tools/mockup.sh to also look for that message. * The LLVM's linker may only print the first dozen errors (omitting the rest to avoid flooding the screen). tools/update-mocks.sh relies on getting all errors as it extracts the missing symbols' names from the error output and creates mocks for them. Detect if errors were omitted and re-run, telling the linker to not omit any. The GNU linker does not support -error-limit=0, so unfortunately we can't just run with that option unconditionally from the first attempt. * Nit: FreeBSD's sed(1) prints "t" for "\t" instead of a horizontal tab. Use a verbatim tab in the command, instead of "\t" which works on both. Changelog-Fixed: Developer mode compilation on FreeBSD.
vasild
force-pushed
the
fix-dev-mode-compilation-fbsd
branch
from
783d2fa
to
0092d4b
Compare
|
ACK 0092d4b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent FreeBSD versions use LLVM's lld as a linker, not the GNU ld.
Their behavior slightly differs, so adapt the build system to handle
either one.
The LLVM's linker prints "undefined symbol:" instead of
"undefined reference to". Tweak tools/mockup.sh to also look for that
message.
The LLVM's linker may only print the first dozen errors (omitting
the rest to avoid flooding the screen). tools/update-mocks.sh relies
on getting all errors as it extracts the missing symbols' names from
the error output and creates mocks for them. Detect if errors were
omitted and re-run, telling the linker to not omit any. The GNU linker
does not support -error-limit=0, so unfortunately we can't just run
with that option unconditionally from the first attempt.
Nit: FreeBSD's sed(1) prints "t" for "\t" instead of a horizontal tab.
Use a verbatim tab in the command, instead of "\t" which works on
both.