lightningd/: Hooks now support a consistent interface for 'no operation'.

[ZmnSCPxj]

Changelog-Changed: The hooks db_write, invoice_payment, and rpc_command now accept { "result": "continue" } to mean "do default action", in addition to true (db_write), {} (invoice_payment), and {"continue": true} (rpc_command). Eventually the older "default" indicators will be deprecated, but for now they will be supported, but logged as UNUSUAL level.

[darosior]

Just a missing return.

Also I think changing test plugins to reflect that would be good(edit: necessary as Travis passed otherwise).
I used darosior@cd329fa for testing if you want to cherry-pick.

[cdecker]

Just needs a compilation guard and implementation of the --deprecated-apis CLI option, so plugins can be tested against them 🙂

For reference github.com/lightningd/plugins tests with --deprecated-apis=false, so we can detect breakage early on.

[ZmnSCPxj]

Deprecated old APIs, fixed code, added test from @darosior, surround with COMPAT_V080 as per @cdecker .

[ZmnSCPxj]

changed a few more test plugin hooks to use the new syntax.

[cdecker]

Seems some headers got jumbled up

if [ x"`LC_ALL=C ls common/*.h | grep -v ^common/gen_`" != x"`echo common/addr.h common/amount.h common/base32.h common/base64.h common/bech32.h common/bech32_util.h common/bigsize.h common/bip32.h common/bolt11.h common/channel_config.h common/close_tx.h common/configdir.h common/crypto_state.h common/crypto_sync.h common/cryptomsg.h common/daemon.h common/daemon_conn.h common/decode_array.h common/derive_basepoints.h common/dev_disconnect.h common/features.h common/fee_states.h common/funding_tx.h common/gossip_rcvd_filter.h common/gossip_store.h common/hash_u5.h common/htlc_state.h common/htlc_trim.h common/htlc_tx.h common/htlc_wire.h common/initial_channel.h common/initial_commit_tx.h common/io_lock.h common/json.h common/json_helpers.h common/json_tok.h common/key_derive.h common/keyset.h common/memleak.h common/msg_queue.h common/node_id.h common/onion.h common/onionreply.h common/param.h common/per_peer_state.h common/peer_billboard.h common/peer_failed.h common/permute_tx.h common/ping.h common/pseudorand.h common/read_peer_msg.h common/socket_close.h common/sphinx.h common/status.h common/status_wire.h common/subdaemon.h common/timeout.h common/type_to_string.h common/utils.h common/utxo.h common/version.h common/wallet.h common/wallet_tx.h common/wireaddr.h common/wire_error.h common/withdraw_tx.h common/errcode.h common/gossip_constants.h common/htlc.h common/json_command.h common/jsonrpc_errors.h common/overflows.h common/status_levels.h | tr ' ' '\n' | LC_ALL=C sort`" ]; then echo COMMON_HEADERS_NOGEN incorrect; exit 1; fi
tests/plugins/hold_invoice.py:14:21: E203 whitespace before ':'
Makefile:314: recipe for target 'check-python' failed
make: *** [check-python] Error 1

And this seems to be related to COMPAT=0:

lightningd/jsonrpc.c: In function ‘rpc_command_hook_callback’:
lightningd/jsonrpc.c:673:7: error: unused variable ‘exec’ [-Werror=unused-variable]
  bool exec;
       ^~~~
lightningd/jsonrpc.c:670:50: error: unused variable ‘tok_continue’ [-Werror=unused-variable]
  const jsmntok_t *tok, *params, *custom_return, *tok_continue;
                                                  ^~~~~~~~~~~~

[darosior]

Needs a tiny rebase otherwise ACK 80377c7

[ZmnSCPxj]

ACK 68cab35

Re-applying @darosior ACK

fixed