Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Start an FAQ #3551

Merged
merged 2 commits into from
Apr 4, 2020
Merged

doc: Start an FAQ #3551

merged 2 commits into from
Apr 4, 2020

Conversation

darosior
Copy link
Collaborator

@darosior darosior commented Feb 26, 2020

This adds an FAQ, I mainly used the issues (thanks for the question label !) but also IRC and face-to-face questions.

Do you have an idea of another topic that could/should be covered here ?

closes #3382


In order to receive payments you need some incoming liquidity, which you can gain by paying
through the channels you opened or by having other peers to open some channels to you.

Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, you can use a service that exchanges Lightning Bitcoins for onchain Bitcoins (so that you do not lose your Bitcoins, or be forced to exchange it for other assets) in order to get incoming liquidity. There also exist services that will, for a fee or for free, create channels to you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep i know about them but i was not sure about promoting them in our faq

Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to name names (specific ones may not be around forever anyway, so ---), at least it gives a hint to the user to search for such services by themselves.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right.

@darosior
Copy link
Collaborator Author

darosior commented Mar 5, 2020

Added @ZmnSCPxj suggestion

Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are definitely better ways to submit copy suggestions than 61 in-line comments, but in my defense i did not set out to make 61 in-line comments when reviewing this, just a few grammatical corrections.

😆

doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
doc/FAQ.md Outdated Show resolved Hide resolved
@darosior
Copy link
Collaborator Author

Thank you very much for this thorough review @niftynei ! Didn't see it before..

@darosior
Copy link
Collaborator Author

Corrected and answered in-line


[Spark-wallet](https://github.com/shesek/spark-wallet/) is the most used remote control,
and care is taken to avoid breaking it too often.
**Use it [behind tor](https://github.com/shesek/spark-wallet/blob/master/doc/onion.md)**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget not everyone proxies their node through a decoy :P

imo this rationale for "why tor" is worth adding to the FAQ.

doc/FAQ.md Outdated Show resolved Hide resolved
block [598000](https://blockstream.info/block/0000000000000000000dd93b8fb5c622b9c903bf6f921ef48e266f0ead7faedb)
(short channel id starting with > 598000) have a high chance of supporting `option_static_remotekey`.

You can verify it using the `features` field from the [`listpeers` command](https://lightning.readthedocs.io/lightning-listpeers.7.html)'s result.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copy/pasting the Python one-liner is the most benefit. It gives readers a quick way to check + it 'educates' the curious as to how feature bits work.

doc/FAQ.md Outdated Show resolved Hide resolved
@niftynei
Copy link
Collaborator

niftynei commented Apr 2, 2020

ACK b081c7d

darosior and others added 2 commits April 2, 2020 12:35
This regroups questions (frequently) seen in Github issues, on IRC, and
also some I've been asked in face to face.

Changelog-Added: doc: An FAQ was added, accessible at https://lightning.readthedocs.io/FAQ.html

Christian wrote the block chain rescaning paragraph.
Lisa corrected my poor english grammar.
Co-Authored-by: Christian Decker <decker.christian@gmail.com>
Co-Authored-by: Lisa Neigut <niftynei@gmail.com>
Tim Ho asked about annouced IP addresses on IRC, and this was not
covered in the FAQ.
@darosior
Copy link
Collaborator Author

darosior commented Apr 2, 2020

Corrected as per the latest review

@niftynei
Copy link
Collaborator

niftynei commented Apr 4, 2020

ACK 6480996

@niftynei
Copy link
Collaborator

niftynei commented Apr 4, 2020

Travis shows the integration tests as passing, but it's not showing up on the approval checklist.

@niftynei niftynei merged commit a5bd36c into ElementsProject:master Apr 4, 2020
@darosior darosior mentioned this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ draft
3 participants