fixup clang error for update-mocks? #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed a update-mocks.sh call
|
@niftynei This appears to be working well now on MacOS 10.15 with Apple clang version 11.0.3 (clang-1103.0.32.29). Thanks! |
According to ElementsProject#3226, it looks like clang's LD error format has changed. This patch adds the new format so we can parse the mocks successfully. Apple clang version 11.0.3 (clang-1103.0.32.29) ``` checking for ANSI C header files... Undefined symbols for architecture x86_64: "_fromwire_amount_msat", referenced from: _fromwire_tlv_test_n1_tlv3 in ccj4zKdV.o "_fromwire_bool", referenced from: _fromwire_test_msg in ccj4zKdV.o _fromwire_test_msg_option_short_id in ccj4zKdV.o _fromwire_test_msg_option_one in ccj4zKdV.o _fromwire_test_msg_option_two in ccj4zKdV.o "_fromwire_test_enum", referenced from: _fromwire_test_msg in ccj4zKdV.o _fromwire_test_msg_option_short_id in ccj4zKdV.o _fromwire_test_msg_option_one in ccj4zKdV.o _fromwire_test_msg_option_two in ccj4zKdV.o "_fromwire_tlvs", referenced from: _fromwire_test_tlv1 in ccj4zKdV.o _fromwire_test_tlv2 in ccj4zKdV.o _fromwire_test_tlv3 in ccj4zKdV.o "_fromwire_tu32", referenced from: _fromwire_tlv_test_n2_tlv2 in ccj4zKdV.o "_fromwire_tu64", referenced from: _fromwire_tlv_test_n1_tlv1 in ccj4zKdV.o _fromwire_tlv_test_n2_tlv1 in ccj4zKdV.o "_fromwire_u16", referenced from: _fromwire_test_features in ccj4zKdV.o _fromwire_subtype_var_assign in ccj4zKdV.o _fromwire_subtype_arrays in ccj4zKdV.o _fromwire_tlv_test_n1_tlv4 in ccj4zKdV.o _fromwire_tlv_test_n3_tlv3 in ccj4zKdV.o _fromwire_test_msg in ccj4zKdV.o _fromwire_test_tlv1 in ccj4zKdV.o ... "_fromwire_u32", referenced from: _fromwire_tlv_test_n3_tlv3 in ccj4zKdV.o _fromwire_test_msg in ccj4zKdV.o _fromwire_test_msg_option_short_id in ccj4zKdV.o _fromwire_test_msg_option_one in ccj4zKdV.o _fromwire_test_msg_option_two in ccj4zKdV.o "_fromwire_u64", referenced from: _fromwire_test_short_id in ccj4zKdV.o _fromwire_tlv_test_n3_tlv3 in ccj4zKdV.o "_fromwire_u8", referenced from: _fromwire_subtype_var_assign in ccj4zKdV.o _fromwire_subtype_var_len in ccj4zKdV.o _fromwire_subtype_varlen_varsize in ccj4zKdV.o _fromwire_tlv_test_n3_tlv3 in ccj4zKdV.o "_fromwire_u8_array", referenced from: _fromwire_test_features in ccj4zKdV.o _fromwire_subtype_arrays in ccj4zKdV.o _fromwire_tlv_test_n3_tlv3 in ccj4zKdV.o _fromwire_test_msg in ccj4zKdV.o _fromwire_test_msg_option_short_id in ccj4zKdV.o _fromwire_test_msg_option_one in ccj4zKdV.o _fromwire_test_msg_option_two in ccj4zKdV.o ... ``` Changelog-Fixed: Build for macOS Catalina / Apple clang v11.0.3 fixed
Adding a small explainer before printing the filename makes it a bit clearer what's going on when parsing make logs
|
Not sure what the force push was, but compiles nicely still on 5e89063. I get some |
|
The force push was to update a commit message 🦖 |
|
Restarted CI since it hit a flake. |
|
ACK 5e89063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for #3226
pinging @willcl-ark for review