An RPC connection fix and some vbyte fun #3772
Conversation
…ution Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
|
ACK 2fbd490 |
lightningd/chaintopology.c
Outdated
| @@ -474,7 +474,7 @@ u32 feerate_from_style(u32 feerate, enum feerate_style style) | |||
| case FEERATE_PER_KBYTE: | |||
| /* Everyone uses satoshi per kbyte, but we use satoshi per ksipa | |||
| * (don't round down to zero though)! */ | |||
| return (feerate + 3) / 4; | |||
| return feerate / 4 + 3; | |||
There was a problem hiding this comment.
Would this lead to us computing a higher feerate than "Everyone" later on?
There was a problem hiding this comment.
I hesitated to use a "return FEERATE_FLOOR if < FEERATE_FLOOR ", but I think we were actually computing lower feerate than bitcoind before this.
There was a problem hiding this comment.
Okay. Will ACK this. Unless you want to change the second commit message.
There was a problem hiding this comment.
Will need to fixup the tests, so will amend the second commit message while at it.
|
ACK 2fbd490 |
|
This messed up all feerate-related tests : now I regret not to have made the API in WU for |
|
Ok, so I went for the "don't go below |
We passed below the floor when the user specified `1000perkb`.
Matt Whitlock says :
I was withdrawing with feerate=1000perkb, which should be the minimum-allowed fee rate. Indeed, bitcoin-cli getmempoolinfo reports:
{
"loaded": true,
"size": 15097,
"bytes": 9207924,
"usage": 32831760,
"maxmempool": 64000000,
"mempoolminfee": 0.00001000,
"minrelaytxfee": 0.00001000
}
Changelog-fixed: rpc: The `feerate` parameters now correctly handle the standardness minimum when passed as `perkb`.
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Reported-by: Matt Whitlock
|
The linked travis build is passing, but it seems github is not noticing it.... |
90bce56: I regularly hit this corner case on a bloated-memory node
9230907 and 2fbd490 fix #3771.
Fixes #3771