Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An RPC connection fix and some vbyte fun #3772

Merged
merged 3 commits into from
Jun 18, 2020

Commits on Jun 16, 2020

  1. lightningd/jsonrpc: don't assume the jcon to be alive at command exec…

    …ution
    
    Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
    darosior committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    90bce56 View commit details
    Browse the repository at this point in the history
  2. pytest: reproduce issue ElementsProject#3591

    Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
    darosior committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9230907 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. rpc: don't go below feerate_floor when converting vbytes

    We passed below the floor when the user specified `1000perkb`.
    Matt Whitlock says :
    
        I was withdrawing with feerate=1000perkb, which should be the minimum-allowed fee rate. Indeed, bitcoin-cli getmempoolinfo reports:
    
        {
          "loaded": true,
          "size": 15097,
          "bytes": 9207924,
          "usage": 32831760,
          "maxmempool": 64000000,
          "mempoolminfee": 0.00001000,
          "minrelaytxfee": 0.00001000
        }
    
    Changelog-fixed: rpc: The `feerate` parameters now correctly handle the standardness minimum when passed as `perkb`.
    Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
    Reported-by: Matt Whitlock
    darosior committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e473129 View commit details
    Browse the repository at this point in the history