fix: channel closer on unilateral to remote #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. What do you mean by "scratching/recovery script"? Example? |
Nothing that I specifically know of, but its something that I can imagine users will come up to check for unclaimed funds in an old backup or something. |
m-schmoock
force-pushed
the
fix/closer_unilateral
branch
3 times, most recently
from
4ab988d
to
915323c
Compare
|
Hopefully the test is now stable ... |
niftynei
reviewed
Nov 13, 2020
|
Reasonable. If someone's going to all the work to close a channel out-of-band, that definitely counts as remote. For what it's worth, we know definitively who did it in onchaind. |
Incase we have been offline while a channel was force closed on us we now set the 'closer' to 'remote' instead of null because this is by far the most probable reason. Changelog-None
m-schmoock
force-pushed
the
fix/closer_unilateral
branch
from
915323c
to
47415ca
Compare
|
ACK 47415ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we set the
lightning-cli listpeerschannelclosertonullif we have been offline and detected a force closed channel on us. This was because in theory it could have been ourself that used some scratching/recovery script for our private keys. Since this is topmost unlikely scenario, especially since someone doing this would certainly not fire up the daemon again and expect it to do something useful, we are better of to set theclosertoremoteas it should be.