lightningd: implement --log-timestamps=false. #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
suppress-timestamps
branch
from
98c3b9d
to
7e8d771
Compare
jsarenik
suggested changes
May 4, 2021
doc/lightningd-config.5
Outdated
| @@ -197,6 +197,11 @@ Log to this file instead of stdout\. Sending \fBlightningd\fR(8) SIGHUP will | |||
| cause it to reopen this file (useful for log rotation)\. | |||
|
|
|||
|
|
|||
| \fBlog-timetamps\fR=\fIBOOL\fR | |||
| Set this to false to turn of timestamp prefixes (they will still appear | |||
There was a problem hiding this comment.
see below (this one is generated)
doc/lightningd-config.5.md
Outdated
| @@ -157,6 +157,10 @@ with multiple daemons. | |||
| Log to this file instead of stdout. Sending lightningd(8) SIGHUP will | |||
| cause it to reopen this file (useful for log rotation). | |||
|
|
|||
| **log-timetamps**=*BOOL* | |||
| Set this to false to turn of timestamp prefixes (they will still appear | |||
There was a problem hiding this comment.
"to turn off", ah this is the source and the other is generated from this
|
Just a minor typo in the docs. ACK 7e8d771 |
cdecker
approved these changes
May 4, 2021
rustyrussell
force-pushed
the
suppress-timestamps
branch
from
7e8d771
to
378a39d
Compare
|
Typo fixed, thanks! |
Fixes: ElementsProject#4494 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
rustyrussell
force-pushed
the
suppress-timestamps
branch
from
378a39d
to
451e189
Compare
|
ACK 451e189 |
jsarenik
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4494
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Added: config: New option
log-timestampsallow disabling of timestamp prefix in logs.