docs: clarify the different way to build cln #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
from
1887a72
to
c8e7680
Compare
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
3 times, most recently
from
e345b83
to
fb4399b
Compare
|
Thanks, I was seeking a grammar review :)
I hope to remove the python deps for not dev after we converge with #5445 and also I would like to avoid putting this file because the people usually when see a requirements.txt tend to do "Ah yes, I do not need to read the install docs it is just pip3 install -r requirements.tx" and after they can not run the test. |
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
from
fb4399b
to
dd706a5
Compare
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
from
dd706a5
to
54095ef
Compare
|
Trivial rebase and make the change requested, thanks to catch my mistake. |
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
from
54095ef
to
107d1c2
Compare
rustyrussell
reviewed
Aug 4, 2022
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/split_dev_doc
branch
from
107d1c2
to
cdb27d9
Compare
|
ACK cdb27d9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will clarify the different ways to build core lightning, and also we speed up the core lightning building process for the people that want just to install cln.
The procedure is already tested by my docker image on alpine is available here
Just thinking also to add how to disable rust if the user does not want to compile the plugin.
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com