Bugfix: Fix 'extreme cases' logging of many commit timer failures #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this about? |
|
I'm fixing dead code. This log appears to be a sanity check which will show up whenever a commitment timer is set before it has received the corresponding revoke and ack for the previous commitment, which isn't allowed by the protocol. Currently it's impossible to actually trigger because of the bug as described. |
rustyrussell
requested changes
Feb 7, 2023
There was a problem hiding this comment.
Needs to initialize commit_timer_attempts at start time:
Valgrind error file: valgrind-errors.74244
==74244== Conditional jump or move depends on uninitialised value(s)
==74244== at 0x110AF6: send_commit (channeld.c:1239)
==74244== by 0x13A03F: timer_expired (timeout.c:62)
==74244== by 0x117ED3: main (channeld.c:4042)
==74244==
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:send_commit
fun:timer_expired
fun:main
}
instagibbs
force-pushed
the
commit_timer_logging
branch
from
7cfbaf6
to
a224587
Compare
|
good catch valgrind; fixed |
rustyrussell
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is impossible for the log line to be hit since the value is set to 1, then reset immediately after to 0. Makes it hard to see if this is happening in a degenerate way.
Changelog-None