channeld: fix update_fee cap. #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would sometimes propose fees which we couldn't afford, and thus the peer would get upset: if we didn't recover it could cause force closes. This was because we didn't take into account that pending htlcs will remove our total available funds. Changelog-Fixes: Protocol: Don't upset peers by sending `update_fee` with fees we cannot afford in the case where HTLCs are large.
rustyrussell
added
the
protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would sometimes propose fees which we couldn't afford, and thus the peer would get upset: if we didn't recover it could cause force closes.
This was because we didn't take into account that pending htlcs will remove our total available funds.
Changelog-Fixes: Protocol: Don't upset peers by sending
update_feewith fees we cannot afford in the case where HTLCs are large.