Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channeld: fix update_fee cap. #7068

Merged
merged 2 commits into from
Feb 13, 2024
Merged

channeld: fix update_fee cap. #7068

merged 2 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. channeld: fix update_fee cap. 

    We would sometimes propose fees which we couldn't afford, and thus the
peer would get upset: if we didn't recover it could cause force closes.

This was because we didn't take into account that pending htlcs will
remove our total available funds.

Changelog-Fixes: Protocol: Don't upset peers by sending `update_fee` with fees we cannot afford in the case where HTLCs are large.
    @rustyrussell
    rustyrussell committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3011e02 View commit details
    Browse the repository at this point in the history

  2. pyetst: Fix up a test checking fees after fee calc change

    @cdecker
    cdecker committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ac2a386 View commit details
    Browse the repository at this point in the history