Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: add low level openchannel methods #7230

Merged

Conversation

daywalker90
Copy link
Contributor

Based on: #7215 + #7217 + #7218

This PR adds the low level openchannel methods:

  • openchannel_abort
  • openchannel_bump
  • openchannel_init
  • openchannel_signed
  • openchannel_update

Aswell as a small fix for methods that contain a '_' like these above.

@daywalker90
Copy link
Contributor Author

Notice that i changed the amount in the json schema to msat

@cdecker
Copy link
Member

cdecker commented Apr 18, 2024

Rebased on top of #7218 now that it is merged into master 👍

Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in denomination in the schema does not match the docs.

contrib/msggen/msggen/schema.json Show resolved Hide resolved
@daywalker90
Copy link
Contributor Author

This one next please: #7238. That CI needs to be running 24/7 or we won't get them all in the 24.05 release

@rustyrussell rustyrussell merged commit fe180e1 into ElementsProject:master Apr 21, 2024
35 checks passed
@daywalker90 daywalker90 deleted the openchannel_low_level branch April 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants