Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: add disableoffer method #7233

Merged
merged 1 commit into from Apr 25, 2024

Conversation

daywalker90
Copy link
Contributor

Based on the fixes from #7215 + #7217 + #7218 and #7230

@cdecker cdecker added this to the v24.05 milestone Apr 22, 2024
@cdecker
Copy link
Member

cdecker commented Apr 22, 2024

This needs a rebase on top of master and then its good to go.

@daywalker90
Copy link
Contributor Author

rebased on master

@cdecker
Copy link
Member

cdecker commented Apr 25, 2024

Rebased, and resolved a bunch of conflicts. The many tiny PR idea is nice, but just does not work if there are conflicts that rebasing brings in. In order for that to work we'd have to have a way to stack the PRs one on top of the other, which GH does not support at all atm for external contributors.

@daywalker90
Copy link
Contributor Author

😢

@cdecker
Copy link
Member

cdecker commented Apr 25, 2024

Ah no worries, I love your contributions, I'm just revising my own mental model on what the ideal flow would be. No criticism intended 🤗

@daywalker90
Copy link
Contributor Author

None taken, it was directed at Github. I tried stacking them all on top of each other in the beginning but you indeed still had to rebase with conflicts every time iirc.

@cdecker cdecker force-pushed the disableoffer branch 2 times, most recently from 81589c3 to 4ef003e Compare April 25, 2024 11:28
@cdecker
Copy link
Member

cdecker commented Apr 25, 2024

Ok, I butchered this PR trying to stack them. I'll reset to your latest version.

@cdecker
Copy link
Member

cdecker commented Apr 25, 2024

Ok, I messed up stacking them, the code was added in #7256, so this is just regenerating the grpc files.

@cdecker cdecker enabled auto-merge (rebase) April 25, 2024 11:35
@cdecker cdecker merged commit dc099a0 into ElementsProject:master Apr 25, 2024
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants