New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msggen: add disableoffer method #7233
Conversation
This needs a rebase on top of |
263d94d
to
9fda8fe
Compare
rebased on master |
Rebased, and resolved a bunch of conflicts. The many tiny PR idea is nice, but just does not work if there are conflicts that rebasing brings in. In order for that to work we'd have to have a way to stack the PRs one on top of the other, which GH does not support at all atm for external contributors. |
😢 |
Ah no worries, I love your contributions, I'm just revising my own mental model on what the ideal flow would be. No criticism intended 🤗 |
None taken, it was directed at Github. I tried stacking them all on top of each other in the beginning but you indeed still had to rebase with conflicts every time iirc. |
81589c3
to
4ef003e
Compare
Ok, I butchered this PR trying to stack them. I'll reset to your latest version. |
Ok, I messed up stacking them, the code was added in #7256, so this is just regenerating the grpc files. |
Based on the fixes from #7215 + #7217 + #7218 and #7230