Add Address type #16
Merged
Add Address type #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with |
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Apr 25, 2019
The new type adds support for blech32 encoding of Element addresses and implements proper version bytes for legacy base58 encoding, removing the need for our modified Address implementation. This depends on @stevenroose's unmerged ElementsProject/rust-elements#16, using his https://github.com/stevenroose/rust-elements/tree/address branch directly. Fixes Blockstream/esplora#79.
|
Tested ACK, implemented in esplora/electrs to add blech32 encoding and decoding (Blockstream/esplora#79). |
apoelstra
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I ported the blech32 code from Elements, but I seem to have some nit somewhere in the checksum code. Still figuring out.