Fix vsize estimation of psbt #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd MAX_TX_FEE_RATIO for fee rate validation feat(LightningService.cs): implement fee rate validation for finalized PSBT using new constants to ensure fees are within acceptable range
…stimation feat(LightningService.cs): add validation for changeless channel operation request with single output refactor(LightningService.cs): improve outputVirtualSize calculation by using estimatedVsize and changelessVSize
# Conflicts: # src/Services/LightningService.cs
Jossec101
commented
Jun 5, 2023
…eration request to check for any outputs instead of count not equal to 1
… operation request to clarify the issue with outputs at this stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(LightningService.cs): add error handling for PSBT virtual size estimation
feat(LightningService.cs): add validation for changeless channel operation request with single output
refactor(LightningService.cs): improve outputVirtualSize calculation by using estimatedVsize and changelessVSize