Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sequence parallelism #812

Closed
Quentin-Anthony opened this issue Mar 7, 2023 · 12 comments · Fixed by #1257
Closed

Add support for sequence parallelism #812

Quentin-Anthony opened this issue Mar 7, 2023 · 12 comments · Fixed by #1257
Assignees
Labels
feature request New feature or request help wanted This issue needs assistance

Comments

@Quentin-Anthony
Copy link
Member

Add sequence parallelism from upstream megatron

@Quentin-Anthony Quentin-Anthony added the feature request New feature or request label Mar 7, 2023
@guozhiyao
Copy link

Hi, do you have any progress on sequence parallelism ?

@Quentin-Anthony
Copy link
Member Author

Not yet. We haven't been able to find someone with the time to implement this yet.

@Quentin-Anthony Quentin-Anthony added the help wanted This issue needs assistance label Mar 27, 2023
@NeverNude
Copy link

I'd be interested in taking this on, if help is still needed here.

@StellaAthena
Copy link
Member

I'd be interested in taking this on, if help is still needed here.

That would be awesome! Someone recently dropped by our discord to volunteer to tackle this, was that you? If not, you should drop by our discord server to coordinate.

@NeverNude
Copy link

Yes that was me! NerevarTheCaptain on discord.

@Quentin-Anthony
Copy link
Member Author

@NeverNude How's this going?

@NeverNude
Copy link

NeverNude commented May 10, 2023 via email

@Quentin-Anthony
Copy link
Member Author

Apologies, I haven't been able to get to this yet, should have an update within the next 7-10 days

On Mon, May 1, 2023 at 9:47 PM Quentin Anthony @.> wrote: @NeverNude https://github.com/NeverNude How's this going? — Reply to this email directly, view it on GitHub <#812 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMTVBSRQ4P2WVJSBNGHJKDXECGUVANCNFSM6AAAAAAVSZQMOA . You are receiving this because you were mentioned.Message ID: @.>

Any update? Anything we can help with?

@NeverNude
Copy link

Apologies, life got way busier than I expected. I am hoping to get to this in the next couple of weeks, but feel free to assign it to somebody else, I don't want to block progress unnecessarily here.

@Quentin-Anthony
Copy link
Member Author

@NeverNude -- Are you still interested in heading this up? Do you have an early version that you can put in a draft PR so that we can add other contributors?

@NeverNude
Copy link

@Quentin-Anthony you should assign it to somebody else at this point. I am unlikely to find the time soon to be able to tackle this, apologies.

@Quentin-Anthony
Copy link
Member Author

Quentin-Anthony commented Oct 4, 2023

@NeverNude -- No worries!

All - we are re-opening this issue to contributors. Reach out if you're interested in tackling it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request help wanted This issue needs assistance
Projects
None yet
4 participants