[Refactor] Upstream ggml from big-refactor branch #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileyschoelkopf
requested review from
lintangsutawika and
StellaAthena
as code owners
Merged
|
Ready for review once CI passes! |
|
Why do we support llama.cp instead of the seemingly more general ggml library? |
|
GGML is written in C, and, to my knowledge, Llama-CPP-Python is the most popular and widely used python + server interface to the library for running GGML/GGUF-formatted models in python code, so that was why it was contributed. To extend GGML support further, I believe the best option is to also support https://github.com/marella/ctransformers . |
StellaAthena
approved these changes
Nov 21, 2023
|
Good to merge @haileyschoelkopf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams the changes in #617 to the
big-refactorbranch.Still TODO: