fix(icons): make sure transparent images have a white background

There was a difference between GD and Imagick
Elgg · Jul 10, 2023 · 25d039b · 25d039b
1 parent c4ad503
commit 25d039b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/engine/classes/Elgg/ImageService.php b/engine/classes/Elgg/ImageService.php
@@ -118,7 +118,12 @@ public function resize(string $source, string $destination = null, array $params
 			}
 
 			$target_size = new Box($max_width, $max_height);
-			$thumbnail = $image->resize($target_size);
+			$image->resize($target_size);
+
+			// create new canvas with a background (default: white)
+			$background_color = elgg_extract('background_color', $params, 'ffffff');
+			$thumbnail = $this->imagine->create($image->getSize(), $image->palette()->color($background_color));
+			$thumbnail->paste($image, new Point(0, 0));
 
 			if (pathinfo($destination, PATHINFO_EXTENSION) === 'webp') {
 				$options = [