Merge pull request #10697 from mrclay/10696_tables

fix(views): in table lists, rows now have IDs
Elgg · Jan 19, 2017 · 273ab5e · 273ab5e
2 parents ac157ba + e42fa63
commit 273ab5e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/views/default/page/components/list.php b/views/default/page/components/list.php
@@ -69,8 +69,10 @@
 		if ($subtype) {
 			$li_attrs['class'][] = "elgg-item-$type-$subtype";
 		}
-	} else if (is_callable(array($item, 'getType'))) {
-		$li_attrs['id'] = "item-{$item->getType()}-{$item->id}";
+	} elseif (is_callable(array($item, 'getType'))) {
+		$type = $item->getType();
+
+		$li_attrs['id'] = "item-$type-{$item->id}";
 	}
 
 	$list_items .= elgg_format_element('li', $li_attrs, $item_view);

diff --git a/views/default/page/components/table.php b/views/default/page/components/table.php
@@ -91,16 +91,18 @@
 		$type = $item->type;
 		$subtype = $item->getSubtype();
 
+		$row_attrs['id'] = "elgg-$type-$guid";
 		$row_attrs['class'][] = "elgg-item-$type";
 		$row_attrs['data-elgg-guid'] = $guid;
 		$row_attrs['data-elgg-type-subtype'] = "$type:$subtype";
 		if ($subtype) {
 			$row_attrs['class'][] = "elgg-item-$type-$subtype";
 		}
 
-	} else if (is_callable(array($item, 'getType'))) {
+	} elseif (is_callable(array($item, 'getType'))) {
 		$type = $item->getType();
 
+		$row_attrs['id'] = "elgg-$type-{$item->id}";
 		$row_attrs['data-elgg-id'] = $item->id;
 		$row_attrs['data-elgg-type'] = $type;
 	}