removed(plugins): the embed plugin has been removed

.scripts/ci/enable_plugins.php

@@ -44,7 +44,6 @@
 
 	// these plugins need to be activated after a previous activated plugin
 	'custom_index',
-	'embed',
 ];
 
 foreach ($ordered_plugins as $priority => $plugin_id) {

.tx/config

@@ -56,12 +56,6 @@ source_file = mod/discussions/languages/en.php
 source_lang = en
 type = PHP_ARRAY
 
-[elgg-core-4.embed]
-file_filter = mod/embed/languages/<lang>.php
-source_file = mod/embed/languages/en.php
-source_lang = en
-type = PHP_ARRAY
-
 [elgg-core-4.externalpages]
 file_filter = mod/externalpages/languages/<lang>.php
 source_file = mod/externalpages/languages/en.php

docs/appendix/upgrade-notes/4.x-to-5.0.rst

@@ -42,6 +42,11 @@ Files plugin
 Files uploaded using the file plugin are no longer stored with the owner but with the file entity. File icons have also been changed. 
 Icon images are only available for image file types. Icon sizes have been changed to use the default icon sizes.
 
+Embed plugin
+------------
+
+The embed plugin has been removed.
+
 Javascript
 ----------
 

docs/guides/javascript.rst

@@ -686,9 +686,6 @@ Available hooks
 **ajax_response_data, \***
     This filters the response data returned to users of the ``elgg/Ajax`` module. See :doc:`ajax` for details.
 
-**insert, editor**
-    This hook is triggered by the embed plugin and can be used to filter content before it is inserted into the textarea. This hook can also be used by WYSIWYG editors to insert content using their own API (in this case the handler should return ``false``). See ckeditor plugin for an example.
-
 Third-party assets
 ==================
 

docs/plugins/index.rst

@@ -28,7 +28,6 @@ The following plugins are also bundled with Elgg, but are not (yet) documented
 - ckeditor
 - custom_index
 - developers
-- embed
 - externalpages
 - friends_collections
 - garbagecollector

engine/classes/Elgg/Config.php

@@ -58,7 +58,6 @@
  * @property string        $emailer_transport                       This is an override for Elgg's default email handling transport (default sendmail)
  * @property array         $emailer_sendmail_settings               This configures SendMail if $emailer_transport is set to "sendmail" or default
  * @property array         $emailer_smtp_settings                   This configures SMTP if $emailer_transport is set to "smtp"
- * @property mixed         $embed_tab
  * @property string        $exception_include						This is an optional script used to override Elgg's default handling of uncaught exceptions.
  * @property int           $friendly_time_number_of_days            Number of days after which timestamps will no longer be presented in a friendly format (x hours ago) but in a full date
  * @property string[]      $http_request_trusted_proxy_ips			When Elgg is behind a loadbalancer/proxy this can contain IP adresses to allow access to better client information

engine/classes/Elgg/Database/Plugins.php

@@ -40,7 +40,6 @@ class Plugins {
 		'dashboard',
 		'developers',
 		'discussions',
-		'embed',
 		'externalpages',
 		'file',
 		'friends',

engine/tests/classes/Elgg/Mocks/Database/Plugins.php

@@ -52,7 +52,6 @@ class Plugins extends DbPlugins {
 
 		// these plugins need to be activated after a previous activated plugin
 		'custom_index',
-		'embed',
 	];
 
 	public function get(string $plugin_id): ?\ElggPlugin {

mod/ckeditor/views/default/elgg-ckeditor.js

@@ -69,19 +69,6 @@ define(function (require) {
 				CKEDITOR.on('instanceReady', elggCKEditor.fixImageAttributes);
 				return CKEDITOR;
 			});
-			hooks.register('embed', 'editor', function (hook, type, params, value) {
-				var textArea = $('#' + params.textAreaId);
-				var content = params.content;
-				if ($.fn.ckeditorGet) {
-					try {
-						var editor = textArea.ckeditorGet();
-						editor.insertHtml(content);
-						return false;
-					} catch (e) {
-						// do nothing.
-					}
-				}
-			});
 			elggCKEditor.registerHandlers = function() {};
 		},
 

mod/developers/lib/functions.php

@@ -42,8 +42,8 @@ function developers_wrap_views(\Elgg\Hook $hook) {
 
 	$excluded_bases = [
 		'resources',
-		'input', // because of possible html encoding in views, which would result in debug cobe being shown to users
-		'output', // because of possible html encoding in views, which would result in debug cobe being shown to users
+		'input', // because of possible html encoding in views, which would result in debug code being shown to users
+		'output', // because of possible html encoding in views, which would result in debug code being shown to users
 		'embed',
 		'icon',
 		'json',