fix(icons): retry icon resize after failure

Elgg · Oct 10, 2023 · e04e396 · e04e396
1 parent 22625d7
commit e04e396
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/engine/classes/Elgg/EntityIconService.php b/engine/classes/Elgg/EntityIconService.php
@@ -401,6 +401,12 @@ protected function generateIcon(\ElggEntity $entity, \ElggFile $file, $type = 'i
 			if (!_elgg_services()->imageService->resize($source, $destination, $resize_params)) {
 				$this->getLogger()->error("Failed to create {$size} icon from
 					{$file->getFilenameOnFilestore()} with coords [{$x1}, {$y1}],[{$x2}, {$y2}]");
+
+				if ($size !== 'master') {
+					// remove 0 byte icon in order to retry the resize on the next request
+					$icon->delete();
+				}
+
 				return false;
 			}
 		}