Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On mobile/tablet, tabs don't need to be blocks #11532

Closed
mrclay opened this issue Dec 22, 2017 · 1 comment
Closed

On mobile/tablet, tabs don't need to be blocks #11532

mrclay opened this issue Dec 22, 2017 · 1 comment

Comments

@mrclay
Copy link
Member

mrclay commented Dec 22, 2017

Particularly for the All/Mine/Friends tabs, these could just stay tabs all the way down to mobile instead of stacking. Can't we just allow all tabs to wrap?
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(css): tabs display as tabs on tablets
09652cb 
This layout allows tabs to wrap in cases where they must.

Fixes Elgg#11532
@mrclay mrclay mentioned this issue Dec 22, 2017
Merged
@jdalsem
Copy link
Member

jdalsem commented Dec 22, 2017

this was an intentional change by @hypeJunction because he only created one breakpoint...

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(css): tabs display as tabs on tablets
87e9d00 
This layout allows tabs to wrap in cases where they must.

Fixes Elgg#11532
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(css): tabs display as tabs on tablets
a6117c2 
This layout allows tabs to wrap in cases where they must.

Fixes Elgg#11532
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 26, 2017
@mrclay
chore(css): tabs display as tabs on tablets
a491947 
This layout allows tabs to wrap in cases where they must.

Fixes Elgg#11532
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 27, 2017
@mrclay
chore(css): tabs display as tabs on tablets
b529530 
This layout allows tabs to wrap in cases where they must.

Fixes Elgg#11532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrclay @jdalsem