Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.xml logic to parse semantic XML (Trac #2225) #2225

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 4 comments
Closed

Update manifest.xml logic to parse semantic XML (Trac #2225) #2225

elgg-gitbot opened this issue Feb 16, 2013 · 4 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2225 on 40385844-09-07 by brettp, assigned to unknown.

Elgg version: Github Master

Currently manifest.xml is in the format:

<field key="name1" value="value1" />
<field key="name2" value="value2" />

I propose using semantic XML instead:

<name1>value1</name1>
<name2>value2</name2>

If this goes in 1.8, we will need to provide backward compatibility with the original format.

@elgg-gitbot
Copy link
Author

brettp wrote on 40773988-12-13

While we're making manifest changes like #2170 and #1986 we should add this.

@elgg-gitbot
Copy link
Author

brettp wrote on 40914964-04-16

(In [svn:7481]) Refs #1986 #2170 #2225 Added ElggPluginManifest, ElggPluginManifestParser, and its parser classes for 1.7 and 1.8 style manifests. Changed load_plugin_manifest() to use new parser. Added initial unit tests.

@elgg-gitbot
Copy link
Author

brettp wrote on 40923092-11-11

(In [svn:7512]) Refs #1986 #2170 #2225. Added semantic manifest.xml support and unit tests. Also added plugin dependencies system. See engine/tests/test_files/plugin_18/manifest.xml for examples. Not closing tickets pending discussion.

@elgg-gitbot
Copy link
Author

brettp wrote on 41007489-12-15

(In [svn:7817]) Fixes #1986, #2170, #2225, #2759. Integrated ElggPluginPackage and ElggPluginManifest with ElggPlugin. System now uses ElggPlugin objects to determin plugins. Order is stored in private settings. This absolutely requires running upgrade.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant