Cannot update annotation name (Trac #3238)

[elgg-gitbot]

Original ticket http://trac.elgg.org/ticket/3238 on 41231095-11-13 by trac user kevinjardine, assigned to cash.

Elgg version: 1.7

The update_annotation function does not let you update the annotation name despite taking it as an argument. There appears to be no way to do this without writing custom SQL.

To fix this, change lines 160-162 in annotations.php from

$result = update_data("UPDATE {$CONFIG->dbprefix}annotations
        set value_id='$value', value_type='$value_type', access_id=$access_id, owner_guid=$owner_guid
        where id=$annotation_id and name_id='$name' and $access");

to

$result = update_data("UPDATE {$CONFIG->dbprefix}annotations
        set value_id='$value', name_id='$name', value_type='$value_type', access_id=$access_id, owner_guid=$owner_guid
        where id=$annotation_id and $access");

[elgg-gitbot]

cash wrote on 41231116-01-09

This is also true for Elgg 1.7

[elgg-gitbot]

Milestone changed to Elgg 1.7.8 by cash on 41234250-05-10

[elgg-gitbot]

cash wrote on 41234253-02-21

(In [svn:8850]) Refs #3238 fix for updating name of metadata for trunk

[elgg-gitbot]

cash wrote on 41234268-08-10

(In [svn:8851]) Fixes #3238 update_metadata() allows updating the name and integrated the fix for #3246 into 1.7 branch

[elgg-gitbot]

cash wrote on 41234297-04-03

(In [svn:8852]) Refs #3238 #3246 anootations needed the same fixes as metadata

[elgg-gitbot]

cash wrote on 41234322-11-22

(In [svn:8853]) Refs #3238 #3246 integrated fixes for annotations into 1.7 branch