Aalborg theme shows "Dashboard" site menu entry when logged out.

[iionly]

Of course the link fails to open the dashboard when you are not logged in. :-)

[juho-jaakkola]

I closed the PR for Aalborg theme. Let's fix this in the dashboard plugin instead.

[iionly]

@juho-jaakkola Would the dashboard plugin really be the right place to "fix" this? It's ONLY the Aalborg theme that changes the behaviour compared to the Elgg default theme (Dashboard link not in Topbar but in site menu instead). If the modification would be made in the code of the dashboard theme the change would be quite the same (checking if a user is logged in and register the menu item only when logged in PLUS a check if the Aalborg theme is used).

Additionally, if someone wants to create a custom theme based on the Aalbord theme (other plugin id), the modification made in the dashboard plugin would be for nothing. So, it seems to me the right place to change the code would be within the Aalborg theme.

[beck24]

Yes this is an aalborg issue, I reopened the PR

[juho-jaakkola]

Sorry, my bad! I was assuming that the issue is caused by the fact that Dashboard plugin doesn't check whether user is logged in before registering the menu item.