Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language keys are not available during upgrades #6249

Closed
mrclay opened this issue Dec 2, 2013 · 1 comment
Closed

New language keys are not available during upgrades #6249

mrclay opened this issue Dec 2, 2013 · 1 comment

Comments

@mrclay
Copy link
Member

mrclay commented Dec 2, 2013

If you need a translation you must call register_translations() on the main language directory before using the new key.

What would be the harm in just calling this before executing any upgrades?

Is this something the new translation system would fix?

@jdalsem
Copy link
Member

jdalsem commented Oct 28, 2014

This is still a problem, but would you accept the easy fix to add a cache invalidation to the "first" upgrade page step (upgrade.php line 63)? Because that will fix your problem.

elgg_invalidate_simplecache();
echo elgg_view_page(elgg_echo('upgrading'), '', 'upgrade');

That will make sure that the (language) cache is invalidated before the upgrade is commencing. The only minor issue is that it will invalidate the cache twice during this process.

@jdalsem jdalsem self-assigned this Feb 23, 2015
jdalsem added a commit to jdalsem/Elgg that referenced this issue Feb 23, 2015
This allows to be able to use new language keys during upgrade.

Fixes Elgg#6249
jdalsem added a commit to jdalsem/Elgg that referenced this issue Feb 24, 2015
This allows to be able to use new language keys during upgrade.

Fixes Elgg#6249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants