Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSMin::minify is restarting Apache #7050

Closed
hypeJunction opened this issue Jul 10, 2014 · 11 comments
Closed

CSSMin::minify is restarting Apache #7050

hypeJunction opened this issue Jul 10, 2014 · 11 comments

Comments

@hypeJunction
Copy link
Contributor

Not entirely sure what's causing this, but something in CSSMin::minify is restarting Apache on Win.

@mrclay
Copy link
Member

mrclay commented Jul 10, 2014

PCRE in PHP is terrible. There's definitely a newer CSSmin available; we could try that.

@mrclay
Copy link
Member

mrclay commented Jul 10, 2014

PCRE config values have to be hand-tuned to handle certain pattern matching scenarios. In other words it's totally broken for anything but small tasks. I get reports about crashes in Minify All The Time.

@hypeJunction
Copy link
Contributor Author

I will avoid it for now. I can compile compressed css from scss sources for my own projects, the rest can just live without compression for now.

@mrclay
Copy link
Member

mrclay commented Jul 10, 2014

Would you mind sending a PR to update this?

@hypeJunction
Copy link
Contributor Author

I would if I had a tiny bit of clue about what's happening there. All the regex makes me dizzy

@jdalsem
Copy link
Member

jdalsem commented Oct 20, 2014

i do not have this problem on my windows installation. Any error message or steps to reproduce?

@hypeJunction
Copy link
Contributor Author

Not really. It could be some piece of CSS I had in my theme. I have disabled the minification and haven't used it since I reported this.

@mrclay
Copy link
Member

mrclay commented Oct 20, 2014

Let's update our copy from the vendor as 1st step.

@jdalsem
Copy link
Member

jdalsem commented Jan 31, 2015

@hypeJunction can you try updating the vendor to see if that is solving this issue for you?

@mrclay
Copy link
Member

mrclay commented Jan 31, 2015

We should switch to https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port, which is the original source of cssmin. Minify just has an old copy.

@hypeJunction
Copy link
Contributor Author

This hasn't manifested itself in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants