-
Notifications
You must be signed in to change notification settings - Fork 669
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSMin::minify is restarting Apache #7050
Comments
PCRE in PHP is terrible. There's definitely a newer CSSmin available; we could try that. |
PCRE config values have to be hand-tuned to handle certain pattern matching scenarios. In other words it's totally broken for anything but small tasks. I get reports about crashes in Minify All The Time. |
I will avoid it for now. I can compile compressed css from scss sources for my own projects, the rest can just live without compression for now. |
Would you mind sending a PR to update this? |
I would if I had a tiny bit of clue about what's happening there. All the regex makes me dizzy |
i do not have this problem on my windows installation. Any error message or steps to reproduce? |
Not really. It could be some piece of CSS I had in my theme. I have disabled the minification and haven't used it since I reported this. |
Let's update our copy from the vendor as 1st step. |
@hypeJunction can you try updating the vendor to see if that is solving this issue for you? |
We should switch to https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port, which is the original source of cssmin. Minify just has an old copy. |
This hasn't manifested itself in a while. |
Not entirely sure what's causing this, but something in CSSMin::minify is restarting Apache on Win.
The text was updated successfully, but these errors were encountered: