Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins can't be activated with a language file with an empty array #8116

Closed
PerJensen opened this issue Apr 3, 2015 · 4 comments
Closed
Assignees

Comments

@PerJensen
Copy link
Contributor

This is the return array and the error:

return array(   
    //'example' => 'Example',
);

customizations (guid: 20) cannot start and has been deactivated.
Reason: Cannot register languages for plugin customizations (guid: 20) at ...

@juho-jaakkola
Copy link
Member

Indeed.

I'm not sure if this should be considered a bug or not. It is maybe a bit overkill to disable the whole plugin.

This problem will most likely be fixed once the overhaul for the i18n code gets finished. Let's keep this open until that.

@PerJensen
Copy link
Contributor Author

Lets do that. Maybe it's not a bug, but I see no reason not to allow the plugin to activate.

@jdalsem
Copy link
Member

jdalsem commented Apr 10, 2015

Provided a PR to fix this, as it plugins are shown as activatable, but crash during activating as the language file was empty. The PR correctly handles the situation where there is a language file, but it returns an empty array

@PerJensen
Copy link
Contributor Author

Nice fix and working, tested manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants