Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset password doesn't properly set salt, causing unusable passwords (Trac #841) #841

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Closed

Reset password doesn't properly set salt, causing unusable passwords (Trac #841) #841

elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Labels
engine important

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/841 on 39180956-03-15 by brettp, assigned to unknown.

Elgg version: 1.2

force_password_update() incorrectly tries to set the password and salt at the same time, but the hash returned by generate_user_password() uses an old salt, making the new password worthless.

This patch updates the salt record first, so generate_user_password() returns a usable password.
@elgg-gitbot
Copy link
Author

Attachment added by brettp on 39180956-12-06: reset_password.patch.gz

@elgg-gitbot
Copy link
Author

trac user marcus wrote on 39182720-04-25

(In [svn:3122]) Closes #841: User request for password changes now functional.

@elgg-gitbot elgg-gitbot mentioned this issue Feb 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine important
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elgg-gitbot