fix(web_services): create_api_user() and create_user_token() work again #10106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclay
force-pushed
the
Wouter0100-patch-7
branch
from
d957040
to
b37a12b
Compare
|
You switched these to crypto only recently. Have they made it into a release already? |
|
Maybe we should add public API for these. I tend to use it now and then |
|
2.2.0 went out with broken web services. |
|
Well, given it's broken, IMO we should just add public API and fix it. I don't necessarily like |
|
We can add API and deprecated the public use of this in 2.x |
| public function __construct(SiteSecret $siteSecret) { | ||
| $this->siteSecret = $siteSecret; | ||
| public function __construct(SiteSecret $site_secret = null) { | ||
| if (!$site_secret) { |
There was a problem hiding this comment.
Eh, I'll just remove this change. This class has always been private API. It's tough love for plugins who go ahead and use it.
These uses of the `ElggCrypto` constructor had not been properly updated when the `SiteSecret` dependency was added.
mrclay
force-pushed
the
Wouter0100-patch-7
branch
from
b37a12b
to
1ee8fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These uses of the
ElggCryptoconstructor had not been properly updated when theSiteSecretdependency was added.(replaces #10100)