feat(admin): makes it easier to navigate plugin dependencies #10312
Conversation
| @@ -71,3 +71,4 @@ startup.sh | |||
| !.gitignore | |||
| !.scripts | |||
| !.tx | |||
| /bower_components/ | |||
There was a problem hiding this comment.
needed for this PR? or something from your own installation
There was a problem hiding this comment.
Looks like some artifact left when switching branches. I will remove.
| )); | ||
| ?> | ||
| <div class="elgg-state-draggable elgg-plugin elgg-state-inactive elgg-state-cannot-activate" id="<?php echo $css_id; ?>"> | ||
| <div class="elgg-image-block"> |
There was a problem hiding this comment.
can't we use elgg_view_image_block?
There was a problem hiding this comment.
I suppose we can.
| ]); | ||
| }, $dependents); | ||
| $name = $this->getManifest()->getName(); | ||
| $list = implode($list); |
|
|
||
| if (!empty($dependents)) { | ||
| $list = array_map(function(\ElggPlugin $plugin) { | ||
| $css_id = preg_replace('/[^a-z0-9-]/i', '-', $plugin->getManifest()->getID()); |
There was a problem hiding this comment.
We use this often. Let's add API
| 'text' => $plugin->getManifest()->getName(), | ||
| 'href' => "#$css_id", | ||
| ]); | ||
| $this->errorMsg = "Conflicts with plugin: $link"; |
There was a problem hiding this comment.
Add translation
|
I agree with your reviewing :) |
|
Cannot deactivate plugins should have a white background, as they're active. And similarly cannot activate plugins should have the light grey background. |
|
Idea: Instead of "Cannot activate" on the button, use "Activate [ban icon]" http://fontawesome.io/icon/ban/ and just take the regular button color and give the whole button opacity:.75. Similarly for Cannot deactivate. I can do this in a follow-up PR. |
|
Not fan of ban icon. Prefer button with disabled atate |
Improves admin plugin management interface by listing plugin dependents and conflicts with shortcut URLs. Modifies some styles and views to make colors less aggressive, texts more readable and anchors recognizable. Adds ElggPlugin::canDeactivate()
Plugins are now activated and deactivated via ajax calls
Improves admin plugin management interface by listing plugin dependents
and conflicts with shortcut URLs. Modifies some styles and views to
make colors less aggressive, texts more readable and anchors recognizable.
Adds ElggPlugin::canDeactivate()