Merge 2.2 into 2.3 #10676
Merged
Merge 2.2 into 2.3 #10676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(core): Check existence of cache symlink without usage of readlink()
For string params, `serialize_parameters` outputs a string literal of PHP code, and `addcslashes` was not appropriate for this task, particularly around escapes in strings. While you can tell it to also escape escape chars, a second pass would be needed. The tests now `eval` the output just as the production code does, and this also makes the tests easier to read.
fix(web_services): handle string params with proper escaping
The `elgg/Ajax` module was auto-converting any request with `options.data` to use the `POST` method. This makes sense for things like actions, which may send a large amount of form data, but it caused `$vars` to not be populated as expected because only `GET` params are injected. If you specified `options.data` with these methods before, note the server will no longer receive this data as `$_POST` on the server. Fixes Elgg#10667
Relative paths to files that contain special characters in the name will now be encoded with base64 to avoid malformatted URLs and HMAC mismatches resulting from unescaped characters. URLs generated prior to this change will continue working. Refs Elgg#10608
fix(files): mitigate issues with special chars in file names
fix(ajax): elgg/Ajax view() and form() set $vars as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.